@flamisz opened this Pull Request on March 4th 2021 Contributor

Description:

fixes #17237

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on March 4th 2021 Contributor

I see some tests are failing now, I'll check those.

@sgiehl commented on March 8th 2021 Member

The changes are looking good I think, but maybe we could add or adjust a test case that queries Live.getLastVisitsDetails with filter_limit=-1 to ensure it returns the correct values.

@sgiehl commented on March 9th 2021 Member

@flamisz Looks good now. Feel free to merge if you are already done with adding tests.

This Pull Request was closed on March 9th 2021
Powered by GitHub Issue Mirror