Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development mode notifications when Matomo not installed through git #17300

Merged
merged 6 commits into from Mar 17, 2021
Merged

Development mode notifications when Matomo not installed through git #17300

merged 6 commits into from Mar 17, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 3, 2021 •
edited

Description:

fixes #16922

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 3, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 3, 2021
sgiehl
sgiehl reviewed Mar 5, 2021
View reviewed changes
plugins/CoreConsole/Commands/GeneratePluginBase.php Outdated Show resolved Hide resolved
lang/en.json Show resolved Hide resolved
@flamisz flamisz added this to the 4.5.0 milestone Mar 9, 2021
sgiehl
sgiehl approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 10, 2021
diosmosis
diosmosis requested changes Mar 14, 2021
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a possible issue but haven't tested locally

core/Plugin/ControllerAdmin.php Show resolved Hide resolved
@sgiehl
Copy link
Member

sgiehl commented Mar 16, 2021

guess should be good to merge now.

@tsteur tsteur modified the milestones: 4.5.0, 4.3.0 Mar 16, 2021
@diosmosis diosmosis merged commit 7527bce into 4.x-dev Mar 17, 2021
@diosmosis diosmosis deleted the 16922-development-mode-check branch March 17, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@diosmosis diosmosis diosmosis requested changes

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

replace generate:plugin warning with pointer to guide
4 participants
@flamisz @sgiehl @diosmosis @tsteur