Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using Piwik when installed as a Composer dependency #173

Merged
merged 2 commits into from Dec 23, 2013

Conversation

craue
Copy link
Contributor

@craue craue commented Dec 22, 2013

No description provided.

@mattab
Copy link
Member

mattab commented Dec 23, 2013

Could you explain the exact workflow you are using?

What is the error if you don't make these changes?

@halfdan
Copy link
Member

halfdan commented Dec 23, 2013

@mattab We had a discussion in IRC about this - the idea is to install Piwik as a composer dependency. The check in Piwik whether all composer dependencies are installed fails since the dependencies aren't in Piwik root dir when Piwik is required as dependency. Error that occurs is that Piwik displays the message to install the composer dependencies..

mattab pushed a commit that referenced this pull request Dec 23, 2013
allow using Piwik when installed as a Composer dependency -- thanks for the PR!
@mattab mattab merged commit b69f873 into matomo-org:master Dec 23, 2013
@mattab
Copy link
Member

mattab commented Dec 23, 2013

@craue I haven't tested this use case but I trust you have.. thanks

@craue
Copy link
Contributor Author

craue commented Dec 25, 2013

With this, Piwik can be installed by just calling php composer.phar require piwik/piwik:~2.0 within a project. All that's left to do is adding an Apache alias (or similar) pointing to vendor/piwik/piwik. It used to work quite well with 1.12 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants