Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide way to extend visitorProfilePopup #17297

Closed
wants to merge 1 commit into from
Closed

Provide way to extend visitorProfilePopup #17297

wants to merge 1 commit into from

Conversation

gtbl2012
Copy link
Contributor

@gtbl2012 gtbl2012 commented Mar 3, 2021

Description:

We find it hard to add custom HTML related to visitor info(userId etc.) in visitorProfilePopup via plugins. Because it doesn't provide any postEvents with visitor info or plugin API to add custom item.

Supplying visitorData to Template.afterVisitorProfileOverview could solve this problem. Making visitorProfilePopup more customizable.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl
Copy link
Member

sgiehl commented Mar 3, 2021

@gtbl2012 Thanks for you PR.
Depending on what you are trying to achieve, it might already be possible with a VisitorDetails class. See https://developer.matomo.org/guides/visitor-log-and-profile

@gtbl2012
Copy link
Contributor Author

gtbl2012 commented Mar 3, 2021

Thanks a lot, implementing ProfileSummary is better. I just missed that part.

@gtbl2012 gtbl2012 closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gtbl2012 @sgiehl