@gtbl2012 opened this Pull Request on March 3rd 2021 Contributor

Description:

We find it hard to add custom HTML related to visitor info(userId etc.) in visitorProfilePopup via plugins. Because it doesn't provide any postEvents with visitor info or plugin API to add custom item.

Supplying visitorData to Template.afterVisitorProfileOverview could solve this problem. Making visitorProfilePopup more customizable.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on March 3rd 2021 Member

@gtbl2012 Thanks for you PR.
Depending on what you are trying to achieve, it might already be possible with a VisitorDetails class. See https://developer.matomo.org/guides/visitor-log-and-profile

@gtbl2012 commented on March 3rd 2021 Contributor

Thanks a lot, implementing ProfileSummary is better. I just missed that part.

This Pull Request was closed on March 3rd 2021
Powered by GitHub Issue Mirror