Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check usernames and emails against each other on user create and update #17296

Merged
merged 2 commits into from Mar 16, 2021
Merged

Check usernames and emails against each other on user create and update #17296

merged 2 commits into from Mar 16, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 3, 2021 •
edited

Description:

fixes #17070

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 3, 2021
@flamisz flamisz added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 3, 2021
@sgiehl sgiehl added this to the 4.5.0 milestone Mar 3, 2021
sgiehl
sgiehl requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments. Otherwise looks good so far.

plugins/UsersManager/tests/Integration/APITest.php Outdated Show resolved Hide resolved
plugins/UsersManager/tests/Integration/APITest.php Outdated Show resolved Hide resolved
plugins/UsersManager/tests/Integration/APITest.php Outdated Show resolved Hide resolved
@flamisz flamisz removed the Needs Review PRs that need a code review label Mar 9, 2021
@sgiehl sgiehl merged commit 9ae5d06 into 4.x-dev Mar 16, 2021
@sgiehl sgiehl deleted the 17070-username-existing-email branch March 16, 2021 13:29
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Prevent new username from using existing user email address
3 participants
@flamisz @sgiehl @mattab