Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent possible warning during GeoIP2 update if providers aren't initialised #17295

Merged
merged 1 commit into from Mar 3, 2021
Merged

Prevent possible warning during GeoIP2 update if providers aren't initialised #17295

merged 1 commit into from Mar 3, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 2, 2021

Description:

refs https://wordpress.org/support/topic/repeated-php-warnings-on-cron-execution/

It should be better to use the method anyway instead of hard coding the variable.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Prevent possible warning during GeoIP2 update if providers aren't ini…
1d5d01d 
…tialised

refs https://wordpress.org/support/topic/repeated-php-warnings-on-cron-execution/

It should be better to use the method anyway instead of hard coding the variable.
@tsteur tsteur added the Needs Review PRs that need a code review label Mar 2, 2021
@tsteur tsteur added this to the 4.3.0 milestone Mar 2, 2021
sgiehl
sgiehl approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@sgiehl sgiehl merged commit 4aa3627 into 4.x-dev Mar 3, 2021
@sgiehl sgiehl deleted the wprepphpwarning branch March 3, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl