@flamisz opened this Pull Request on March 2nd 2021 Contributor

Description:

fixes #17080

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@sgiehl commented on March 9th 2021 Member

I guess the change is fine. Seems we currently don't have any unit tests for the periods class in javascript. Might maybe be good to at least add some basic tests that covers some of the edge cases that were making trouble.
@flamisz Not sure if you already had a look at the angularjs tests. They are located with the javascript files but are named *.spec.js

@flamisz commented on March 10th 2021 Contributor

You were right @sgiehl, the tests are important. I found one other very similar issue this way 😄 .

This Pull Request was closed on March 11th 2021
Powered by GitHub Issue Mirror