Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use language files for create user form #17293

Merged
merged 1 commit into from Mar 8, 2021
Merged

Use language files for create user form #17293

merged 1 commit into from Mar 8, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 2, 2021 •
edited by sgiehl

Description:

fixes #17086

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 2, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 2, 2021
@sgiehl sgiehl added this to the 4.5.0 milestone Mar 3, 2021
sgiehl
sgiehl approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgiehl sgiehl merged commit 7b8d882 into 4.x-dev Mar 8, 2021
@sgiehl sgiehl deleted the 17086-language-files-for-create-new-user-field-names branch March 8, 2021 16:50
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Translation missed on "Create a new user"
3 participants
@flamisz @sgiehl @mattab