New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track JS errors only once per page view #17288
Conversation
build js |
build js |
build js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
@tsteur Not sure if that is something we should mention in the changelog. Or maybe we should update https://matomo.org/faq/how-to/how-do-i-enable-basic-javascript-error-tracking-and-reporting-in-matomo-browser-console-error-messages/ after merging and mention, that each error will only be tracked once?
@tsteur I think it's a good idea to mention it somewhere, we only track once per page view. The original issue name will get into the changelog, won't it? |
build js |
@flamisz updated https://matomo.org/faq/how-to/how-do-i-enable-basic-javascript-error-tracking-and-reporting-in-matomo-browser-console-error-messages/ and could also add it to the developer changelog https://github.com/matomo-org/matomo/blob/4.x-dev/CHANGELOG.md . wouldn't need to mention the issue number |
build js |
@tsteur @sgiehl is this something we'd want to write a quick test for in https://github.com/matomo-org/matomo/blob/4.x-dev/tests/javascript/index.php |
Yes, it be great to have a quick test for it 👍 |
build js |
@flamisz seems the javascript tests are still failing |
build js |
Hi @sgiehl, I fixed the js tests, but now the Travis CI - Pull Request build failed. What could it be? Is there a way to rebuild it? I couldn't find any (obviously without pushing any changes). |
@flamisz there should be a "restart build" button: you may need to authorize your github account w/ travis if it's not there (it might be in settings after logging in). EDIT: that said, we generally only need one build to pass. |
build js |
build js |
Description:
fixes #17163
Review