@flamisz opened this Pull Request on March 2nd 2021 Contributor

Description:

fixes #17163

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@flamisz commented on March 2nd 2021 Contributor

build js

@flamisz commented on March 2nd 2021 Contributor

build js

@sgiehl commented on March 9th 2021 Member

build js

@flamisz commented on March 11th 2021 Contributor

@tsteur I think it's a good idea to mention it somewhere, we only track once per page view. The original issue name will get into the changelog, won't it?

@tsteur commented on March 11th 2021 Member

build js

@tsteur commented on March 11th 2021 Member
@flamisz commented on March 11th 2021 Contributor

build js

@diosmosis commented on March 14th 2021 Member

@tsteur @sgiehl is this something we'd want to write a quick test for in https://github.com/matomo-org/matomo/blob/4.x-dev/tests/javascript/index.php

@tsteur commented on March 14th 2021 Member

Yes, it be great to have a quick test for it 👍

@flamisz commented on March 15th 2021 Contributor

build js

@sgiehl commented on March 16th 2021 Member

@flamisz seems the javascript tests are still failing

@flamisz commented on March 17th 2021 Contributor

build js

@flamisz commented on March 17th 2021 Contributor

Hi @sgiehl, I fixed the js tests, but now the Travis CI - Pull Request build failed. What could it be? Is there a way to rebuild it? I couldn't find any (obviously without pushing any changes).

@diosmosis commented on March 17th 2021 Member

@flamisz there should be a "restart build" button:
image

you may need to authorize your github account w/ travis if it's not there (it might be in settings after logging in).

EDIT: that said, we generally only need one build to pass.

@flamisz commented on March 28th 2021 Contributor

build js

@flamisz commented on March 28th 2021 Contributor

build js

This Pull Request was closed on March 28th 2021
Powered by GitHub Issue Mirror