Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for password confirmation before installing all plugins #17285

Merged
merged 1 commit into from Mar 1, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 1, 2021

Description:

Installing a single password currently requires a password confirmation.
This should also be done when installing multiple plugins using a license key.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Mar 1, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 1, 2021
@diosmosis diosmosis merged commit 265046a into 4.x-dev Mar 1, 2021
@diosmosis diosmosis deleted the pwcheck branch March 1, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants