Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the text "(Default)" in the new segment screen #17277

Merged
merged 2 commits into from Feb 28, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Feb 26, 2021

Description:

ref: #17129

The default value depends on the enable_browser_archiving_triggering settings. The easiest fix to delete the default in the name, so it won't be confusing if someone set that value to false.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Feb 26, 2021
@flamisz flamisz added the Needs Review PRs that need a code review label Feb 26, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me to completely remove the Default text.

@diosmosis diosmosis added this to the 4.2.1 milestone Feb 28, 2021
@diosmosis diosmosis merged commit 1c03c4e into 4.x-dev Feb 28, 2021
@diosmosis diosmosis deleted the 17129-new-segment-default branch February 28, 2021 18:09
@mattab mattab changed the title delete default in new segment type name Remove the text "(Default)" in the new segment type name Mar 1, 2021
@mattab mattab changed the title Remove the text "(Default)" in the new segment type name Remove the text "(Default)" in the new segment screen Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants