Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send performance information along a page view only when performance tracking is enabled #17275

Closed
wants to merge 2 commits into from
Closed

Send performance information along a page view only when performance tracking is enabled #17275

wants to merge 2 commits into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 25, 2021

Description:

fix #17267

I reckon no test is needed.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 25, 2021
@tsteur tsteur added this to the 4.3.0 milestone Feb 25, 2021
@tsteur
Copy link
Member Author

tsteur commented Feb 25, 2021

build js

@tsteur tsteur mentioned this pull request Feb 25, 2021
Closed
@sgiehl
Copy link
Member

sgiehl commented Feb 25, 2021

guess this replaces #17268

@tsteur
Copy link
Member Author

tsteur commented Feb 25, 2021

didn't notice there was already a PR. Will close this one.

@tsteur tsteur closed this Feb 25, 2021
@tsteur tsteur deleted the f17267 branch February 25, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

trackPageView still sends page performance report after disablePerformanceTracking
2 participants
@tsteur @sgiehl