Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not append performance metrics to page view log if performance tracking disabled #17268

Merged
merged 2 commits into from Mar 2, 2021
Merged

Do not append performance metrics to page view log if performance tracking disabled #17268

merged 2 commits into from Mar 2, 2021

Conversation

ufoproger
Copy link
Contributor

@ufoproger ufoproger commented Feb 25, 2021 •
edited

Closes #17267

Description:

Completely disable performance metrics if disablePerformanceTracking called.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@ufoproger ufoproger changed the title Closes #17267: trackPageView still sends page performance report after disablePerformanceTracking Do not append performance metrics to page view log if performance tracking disabled Feb 25, 2021
@sgiehl sgiehl mentioned this pull request Feb 25, 2021
Closed
9 tasks
@tsteur tsteur added this to the 4.3.0 milestone Feb 25, 2021
@tsteur tsteur added the Needs Review PRs that need a code review label Feb 25, 2021
@diosmosis diosmosis merged commit 6e03026 into matomo-org:4.x-dev Mar 2, 2021
@diosmosis
Copy link
Member

Hi @ufoproger, thanks for the great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

trackPageView still sends page performance report after disablePerformanceTracking
4 participants
@ufoproger @diosmosis @sgiehl @tsteur