Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trackPageView still sends page performance report after disablePerformanceTracking #17267

Closed
ufoproger opened this issue Feb 25, 2021 · 2 comments · Fixed by #17268
Closed

trackPageView still sends page performance report after disablePerformanceTracking #17267

ufoproger opened this issue Feb 25, 2021 · 2 comments · Fixed by #17268
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.3.0

Comments

@ufoproger
Copy link
Contributor

Expected Behavior

Disable all performance tracking. This feature required for single page application (SPA).

Current Behavior

With disablePerformanceTracking all page views contains old page performance.
Without disablePerformanceTracking first request contains not complete page performance (without DOM info), second request contains full page performance and other next requests does not contain page performance data.

Possible Solution

Additionally check variable configPerformanceTrackingEnabled before calling appendAvailablePerformanceMetrics(request).

Steps to Reproduce (for Bugs)

  1. Create single page application;
  2. Push disablePerformanceTracking;
  3. Track page view — page performance is sent;
  4. Change window.location;
  5. Track page view — old page performance is sent.

Context

SPA without page reload.

Your Environment

  • Matomo Version: 4.2.0
  • PHP Version: PHP/7.4.15
    Server Operating System: Docker image matomo:4.2.0
  • Additionally installed plugins: none
@ufoproger ufoproger added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Feb 25, 2021
@ufoproger ufoproger mentioned this issue Feb 25, 2021
Merged
9 tasks
@tsteur tsteur self-assigned this Feb 25, 2021
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Feb 25, 2021
tsteur added a commit that referenced this issue Feb 25, 2021
@tsteur
Send performance information along a page view only when performance …
ec61a4c 
…tracking is enabled

fix #17267
@tsteur tsteur mentioned this issue Feb 25, 2021
Closed
9 tasks
@tsteur
Copy link
Member

tsteur commented Feb 25, 2021

Hi @ufoproger thanks for reporting this bug and the suggestion for the solution 👍 very appreciated. I've created the PR in #17275 and the fix should be included in the 4.3.0 release (not the next 4.2.1 release)

@tsteur tsteur added this to the 4.3.0 milestone Feb 25, 2021
@tsteur
Copy link
Member

tsteur commented Feb 25, 2021

Sorry didn't notice you had already created a PR. closed mine again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.3.0
2 participants
@ufoproger @tsteur