@flamisz opened this Pull Request on February 25th 2021 Contributor

Description:

ref #15501

Turned out it's not fixing the original issue. For more details see the comments on that issue.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on March 10th 2021 Contributor

@tsteur and @sgiehl I found something interesting with this action_name while I was writing a test.
I modified back my changes to see the test a made is failing, but it's not. So I checked and we already trim the action name, but not there where I modified the code.

https://github.com/matomo-org/matomo/blob/b17616097d6b353dc65b0d77773d0c78977646e8/core/Tracker/ActionPageview.php#L28-L29

and then:

https://github.com/matomo-org/matomo/blob/b17616097d6b353dc65b0d77773d0c78977646e8/core/Tracker/Action.php#L212-L215

So this couldn't be the original issue. I can add the tests and not modifying the code, so we will see actually it is trimmed.
But then what was the issue for the user?

@sgiehl commented on March 10th 2021 Member

@flamisz Had a closer look at the code myself now and it seems the action name is trimmed in all cases already. I guess there are actually no changes needed. Will comment the original issue as well.

@sgiehl commented on March 15th 2021 Member

Merging this one as an additional test can't hurt ;-)

This Pull Request was closed on March 15th 2021
Powered by GitHub Issue Mirror