Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify hover text #17264

Merged
merged 2 commits into from Mar 14, 2021
Merged

modify hover text #17264

merged 2 commits into from Mar 14, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Feb 24, 2021 •
edited

Description:

fixes #16374

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Feb 24, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 24, 2021
@tsteur tsteur mentioned this pull request Mar 8, 2021
Closed
@flamisz flamisz added this to the 4.4.0 milestone Mar 9, 2021
sgiehl
sgiehl approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected.

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 9, 2021
@diosmosis diosmosis merged commit 8a8cb63 into 4.x-dev Mar 14, 2021
@diosmosis diosmosis modified the milestones: 4.4.0, 4.3.0 Mar 14, 2021
@diosmosis diosmosis deleted the 16374-site-search-hover branch March 14, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Site Search hover help bug
3 participants
@flamisz @sgiehl @diosmosis