@diosmosis opened this Pull Request on February 24th 2021 Member

Description:

Fixes #16222

The only instance of unique visitors I could find when processing was disabled was in VisitsSummary.get, and I noticed the metric is enabled everywhere in this case. This removes the metric everywhere if processing is disabled.

Note: this will also remove the metric even if there is existing data. So if a user computes it for months initially, then disables it for months, the old data won't be visible. Not sure if this is desired (cc @tsteur/@mattab).

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on March 2nd 2021 Member

@mattab / @tsteur can you tell me if this is desired behavior:

Note: this will also remove the metric even if there is existing data. So if a user computes it for months initially, then disables it for months, the old data won't be visible. Not sure if this is desired

@tsteur commented on March 2nd 2021 Member

@diosmosis I reckon that's fine 👍

This Pull Request was closed on March 7th 2021
Powered by GitHub Issue Mirror