Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countries and Continents #1726

Closed
robocoder opened this issue Sep 24, 2010 · 1 comment
Closed

Countries and Continents #1726

robocoder opened this issue Sep 24, 2010 · 1 comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@robocoder
Copy link
Contributor

The MaxMind GeoIP database contains some extra codes that we should define in core/DataFiles/Countries.php and lang/en.php.

At the same time, we should re-align the country-to-continent mapping using www.maxmind.com/app/country_continent. This shifts the responsibility for "accuracy" to a third-party.

Another issue that arises is that the GeoIP query appears to sometimes return an empty string (instead of 'xx' or 'unk'), resulting in UserCountry_country_ and UserCountry_continent_.

@robocoder
Copy link
Contributor Author

(In [3174]) fixes #1726 - add Antarctica and Central America; use MaxMind's country-to-continent mapping (with the exception of Central America which it groups with North America).

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

1 participant