@robocoder opened this Issue on September 24th 2010 Contributor

The MaxMind GeoIP database contains some extra codes that we should define in core/DataFiles/Countries.php and lang/en.php.

  • "A1", "A2", "O1", and "AP" (www.maxmind.com/app/iso3166)

At the same time, we should re-align the country-to-continent mapping using www.maxmind.com/app/country_continent. This shifts the responsibility for "accuracy" to a third-party.

Another issue that arises is that the GeoIP query appears to sometimes return an empty string (instead of 'xx' or 'unk'), resulting in UserCountrycountry and UserCountrycontinent.

@robocoder commented on September 24th 2010 Contributor

(In [3174]) fixes #1726 - add Antarctica and Central America; use MaxMind's country-to-continent mapping (with the exception of Central America which it groups with North America).

This Issue was closed on September 24th 2010
Powered by GitHub Issue Mirror