New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not supported browser exception #17258
Conversation
Looks good so far. We could maybe add a UI test to make sure this will keep working. @flamisz it's possible to manipulate the useragent used in UI tests (see https://github.com/matomo-org/matomo/blob/4.x-dev/tests/UI/specs/OptOutForm_spec.js) |
Do I understand it correctly that this runs the users user-agent through device-detector on any single request? I can imagine that there are quite a few slow servers out there (or ones without regex-caching) where this could add more than just a few milliseconds to every request. Maybe just adding it to the login should be enough (unless that's what the code already does). |
BTW only running it on login could work for regular requests but for widgets it would always need to run (eg when |
@tsteur I modified the logic: only checks the browser if the user is |
…-org/matomo into 16776-unsupported-browser-warning
Hey @tsteur I modified the PR according to your comments. Please view it again when you have some time. Thanks |
@flamisz overall looks good from my perspective 👍 but didn't test it |
@tsteur I did my best to test on a couple of browsers and a couple of use cases with BrowserStack. |
👍 feel free to merge if the tests pass (didn't check) |
This leads to HTTP 500 errors that alert my server monitoring; additionally, 5xx is not the right kind of status code for such conditions. Maybe |
@mpdude thanks for your suggestion. Would you mind creating a new issue for that referencing this PR. We likely might forget about that if there is no separate issue we can plan to work on. |
Description:
fixes #16776
Review