Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quick test for userId using ints #17256

Merged
merged 1 commit into from Feb 23, 2021
Merged

add quick test for userId using ints #17256

merged 1 commit into from Feb 23, 2021

Conversation

diosmosis
Copy link
Member

Description:

Refs #17252

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 23, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Feb 23, 2021
@diosmosis diosmosis merged commit f8ad318 into 4.x-dev Feb 23, 2021
@diosmosis diosmosis deleted the 17252-test branch February 23, 2021 23:17
@sgiehl
Copy link
Member

sgiehl commented Feb 24, 2021

@diosmosis seems this has introduced some failures in javascript tests

@diosmosis
Copy link
Member Author

@sgiehl fixed in 4.x-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants