Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In current piwik tracker, the 'setUserId' using 'isNumberOrHasLength' to check the 'userId'.
while the 'getRequest' function using '(configUserId && configUserId.length)' to check the 'userId'.
Which causing user can set a userId in number and verify it by 'getUserId' func, but the userId cannot be reported.
This PR is to solve this confusing thing.
Review