Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new github action to automatically update all submodules #17251

Merged
merged 1 commit into from Feb 24, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 23, 2021

Description:

Our submodules seems to be out of sync quite often. This new action will automatically create a PR for updating the submodules once a week (could also do that more often if useful). In addition it's possible to trigger the action manually. This can be used before building a release.

Note: I've built this action to prevent having outdated submodules before a release is done. In the latest release the the log-analytics submodule for example was out of sync. Therefor a feature that was mentioned in the changelog actually wasn't included.

refs #8425

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 23, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Feb 23, 2021
@tsteur tsteur modified the milestones: 4.3.0, 4.5.0 Feb 23, 2021
@diosmosis
Copy link
Member

@sgiehl based on slack discussion will merge and see if it works, if not will revert and wait until 4.5.0

@diosmosis diosmosis merged commit 45c7767 into 4.x-dev Feb 24, 2021
@diosmosis diosmosis deleted the submoduleaction branch February 24, 2021 03:13
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants