@diosmosis opened this Pull Request on February 23rd 2021 Member

Description:

If we don't do this, then no matter what, on pluginOnly archiving requests, we end up initiating archiving for subperiods, even if data exists.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on February 23rd 2021 Member

It would make sense. I couldn't think of an easy way to do it though, I'll think a bit more.

@diosmosis commented on February 24th 2021 Member

@sgiehl added a test

@sgiehl commented on February 24th 2021 Member

There seem to be some failing tests. Not sure if it related to the changes here. Besides that it looks good to merge

This Pull Request was closed on February 25th 2021
Powered by GitHub Issue Mirror