Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct multisite image url #17249

Merged
merged 2 commits into from Feb 23, 2021
Merged

Correct multisite image url #17249

merged 2 commits into from Feb 23, 2021

Conversation

Findus23
Copy link
Member

fixes #17248

@Findus23 Findus23 added the Needs Review PRs that need a code review label Feb 22, 2021
@diosmosis
Copy link
Member

Using ?module= is actually done throughout matomo. This seems more like a server configuration issue to me? Given matomo requests should almost always go to index.php by default.

@Findus23
Copy link
Member Author

While I agree that this is a server configuration issue, I didn't see any other Matomo requests that don't use index.php in the URL.
Both URLs linked to like index.php?module=CoreAdminHome&action=home and API requests like index.php?date=today&module=UserCountryMap always seem to include the index.php part in the URL.

@diosmosis
Copy link
Member

Those, I'm guessing, go through a single code path (ie, piwik-api.js) so would be uniform. I'm sure there are links in matomo, however, that link to ?.... I guess we can still change this one though.

@diosmosis diosmosis merged commit 83cb08d into 4.x-dev Feb 23, 2021
@diosmosis diosmosis deleted the correct-multisite-image-url branch February 23, 2021 17:22
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All websites dashboard images may show as 404
3 participants