possibly avoid infinite looping if group_concat cuts off result #17244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Needs Review
sgiehl
requested changes
Feb 23, 2021
core/DataAccess/Model.php
Outdated
Comment on lines
54
to
55
| * @param array $idSites | ||
| * @param bool $setMaxLen for tests only |
There was a problem hiding this comment.
Suggested change
| * @param array $idSites | |
| * @param bool $setMaxLen for tests only | |
| * @param bool $setGroupContentMaxLen for tests only |
|
@sgiehl applied pr feedback |
sgiehl
reviewed
Feb 24, 2021
sgiehl
approved these changes
Feb 24, 2021
|
Looks good @diosmosis is the test https://travis-ci.com/github/matomo-org/matomo/jobs/485720146#L778 failing because of this PR? Feel free to merge otherwise |
|
@tsteur was looking at this yesterday. Something changed w/ the tracking, now only one visit gets tracked. Looking into why. |
|
build failure was random. I was able to reproduce it locally yesterday, but not today... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As title, test forthcoming.
Review