Matomo Pull Request #17244 - possibly avoid infinite looping if group

@diosmosis opened this Pull Request on February 22nd 2021 Member

As title, test forthcoming.

[ ] Functional review done
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done see checklist
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

@diosmosis commented on February 24th 2021 Member

@sgiehl applied pr feedback

@tsteur commented on February 25th 2021 Member

Looks good @diosmosis is the test https://travis-ci.com/github/matomo-org/matomo/jobs/485720146#L778 failing because of this PR? Feel free to merge otherwise

@diosmosis commented on February 25th 2021 Member

@tsteur was looking at this yesterday. Something changed w/ the tracking, now only one visit gets tracked. Looking into why.

@diosmosis commented on February 25th 2021 Member

build failure was random. I was able to reproduce it locally yesterday, but not today...

This Pull Request was closed on February 25th 2021

possibly avoid infinite looping if group_concat cuts off result #17244