Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename testcookie to make it clear it is created by Matomo #17243

Merged
merged 5 commits into from Mar 9, 2021

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Feb 22, 2021

inspired by https://forum.matomo.org/t/is-cookie-test-with-value-testvalue-set-by-matomo/40775/2

The cookie's name doesn't start with _pk, so it isn't obvious it is created by Matomo.

I also named the cookie _pk_testcookie_domain, so it isn't confused with this testcookie:

matomo/js/piwik.js

Lines 3043 to 3044 in bd7e099

var testCookieName = configCookieNamePrefix + 'testcookie';
setCookie(testCookieName, '1', undefined, configCookiePath, configCookieDomain, configCookieIsSecure, configCookieSameSite);

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review labels Feb 22, 2021
@Findus23
Copy link
Member Author

build js

Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

js/piwik.js Outdated Show resolved Hide resolved
@Findus23
Copy link
Member Author

Findus23 commented Mar 9, 2021

build js

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 9, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 9, 2021
@diosmosis diosmosis merged commit b176160 into 4.x-dev Mar 9, 2021
@diosmosis diosmosis deleted the testcookie-name branch March 9, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants