New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance report table not displayed properly #17242
Comments
Be great to check if this is indeed a regression (not sure we changed anything there or not). If not, feel free to remove the regression label and unassign the milestone. |
On demo.matomo.cloud (which is still on 4.1.1) this is displayed perfectly fine, so I'm pretty sure this is a 4.2.0 regression |
The table width difference is coming from the header row: in German, the worlds are longer, like There was a language file update in January which made it to version 4.2: That causes the issue. Any recommendation to solve it? Modify the logic of how we show the labels in the header row? Use some max-width? Or modifying the language file itself? |
Changing the translations won't make much sense, as it could be changed again anytime, also the words might be much longer in other languages. |
Yes, that's true. I can modify the css of the header rows to cut the text if too long (hovering will show some extra info anyway). |
I'm not the biggest fan of truncating the header rows.
which doesn't really feel that much more useful than the current status. To be fair, I can't think of a better solution. I don't even know a way to make the German translation any shorter. |
Truncating doesn't make much sense though. If we do that it would be even better to cut out the middle, so you see beginning and end, which should make it easier to identify columns. |
We could also just leave things the way they are as it's maybe not too bad and smaller font size and other things may be bit more of a compromise? |
This suggestion might be a bit late, but if nothing else provides a good solution, we could break individual long words up and allow multi-line cell headers (if not allowed already). For example:
|
I like @diosmosis suggestion. That was my original idea, just wrap the text for equal lines, but looked weird, but just because I haven't added the I'll make some screenshots for different solutions and share it here. |
The three variants: Current solution: Solution with hyphens (this is css): The 3rd one is very simple, I can just create a What do you prefer? @diosmosis @tsteur @sgiehl @Findus23 |
I think I'll save my opinion until german speakers weigh in because I have no idea if that's more readable or not. :) |
For german the last option would work. But can't say anything about other languages. |
@sgiehl I used this for the screenshot, but planning to double check how it works in different browsers: .hyphenate {
word-wrap: break-word;
overflow-wrap: break-word;
-webkit-hyphens: auto;
-moz-hyphens: auto;
hyphens: auto;
} |
Unfortunately the css solution is not perfect. It works well in firefox and safari for me, but in chrome it looks like this: We can add this css, probably doesn't hurt anything, but won't be perfect for everyone, on every language, and on every browser. The other option is to revisit how @tsteur what do you think? Keep it as it is? Use this css? Or rethink how we calculate the width? |
Hi, just checked using |
@tsteur Changed it to |
Great, thanks @sgiehl 👍 I think we can close this issue? |
It might actually happen again for any column with a longer name in any language. But we can always reconsider fixing it another way I guess |
Yes that's the idea. If there are issues again in other languages where they are using the abbreviation and the label column gets way too wide then we can look into it again if needed. |
reported in https://forum.matomo.org/t/version-4-2-0-darstellungsfehler/40770
This might be a regression of 4.2.0.
The tables in the Behaviour -> Performance reports have a very wide first column when displayed in German (English seems to be fine) causing a horizontal scrollbar to be needed to see all columns.
The text was updated successfully, but these errors were encountered: