Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix force-report parameter for core:archive #17236

Merged
merged 1 commit into from Feb 19, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 19, 2021

Description:

The parameter actually needs the possibility to define a value

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 19, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Feb 19, 2021
@diosmosis diosmosis merged commit bbaea5e into 4.x-dev Feb 19, 2021
@diosmosis diosmosis deleted the fixreportarchiving branch February 19, 2021 18:31
@diosmosis
Copy link
Member

diosmosis commented Feb 19, 2021

🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants