Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask users to refer us to other friends #17234

Merged
merged 17 commits into from Mar 17, 2021
Merged

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Feb 19, 2021

Description:

fixes #16803

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Feb 19, 2021
@flamisz flamisz changed the title skeleton for the refer banner 16803 - Ask users to refer us to other friends Feb 21, 2021
@flamisz
Copy link
Contributor Author

flamisz commented Feb 21, 2021

I haven't find a way to share on mastodon with a link, so that button is hidden on the ui.
The FB share currently not working, as matomo.org is on spam-list at FB.

I fixed a small bug with the feedback popup: it called the remindMeLater method even when the user clicked on the never remind me button, so actually the user was reminded again in 90 days.

@flamisz flamisz marked this pull request as ready for review February 22, 2021 06:22
@flamisz flamisz added the Needs Review PRs that need a code review label Feb 22, 2021
@Findus23
Copy link
Member

@flamisz If you want to make it a bit more complex, you could add a input field for people to enter their Mastodon URL and then redirect them to https://mastodon.example/share?text=the%20text
grafik

Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, before I forget:
All texts should probably be translatable.

@flamisz
Copy link
Contributor Author

flamisz commented Feb 22, 2021

One minor thing, before I forget:
All texts should probably be translatable.

@Findus23 yes, that's a good point. for sure it should be. I will do that

@flamisz flamisz marked this pull request as draft February 22, 2021 21:15
@flamisz flamisz removed the Needs Review PRs that need a code review label Feb 22, 2021
@flamisz flamisz marked this pull request as ready for review February 23, 2021 01:08
@flamisz flamisz added the Needs Review PRs that need a code review label Feb 23, 2021
@mattab mattab changed the title 16803 - Ask users to refer us to other friends Ask users to refer us to other friends Feb 23, 2021
@flamisz flamisz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 1, 2021
@flamisz flamisz added this to the 4.3.0 milestone Mar 9, 2021
@flamisz flamisz requested a review from Findus23 March 10, 2021 21:25
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some potential UX issues (cc @mattab / @tsteur):

  • I noticed if you click one link the bottom area disappears. So if a user clicks on twitter, it goes to twitter.com, then they go back and want to click on another link (say linkedin), they're no longer able to. It doesn't seem like that big of a deal given the scope of the change, but it's something I noticed.

@mattab / @tsteur can you look at and approve the ux and copy?

banner at the bottom of the page:

image

thank you popup after clicking refer:

image

plugins/Feedback/Controller.php Show resolved Hide resolved
plugins/Feedback/Feedback.php Show resolved Hide resolved
@diosmosis diosmosis removed the Needs Review PRs that need a code review label Mar 14, 2021
@tsteur
Copy link
Member

tsteur commented Mar 14, 2021

I noticed if you click one link the bottom area disappears. So if a user clicks on twitter, it goes to twitter.com, then they go back and want to click on another link (say linkedin), they're no longer able to. It doesn't seem like that big of a deal given the scope of the change, but it's something I noticed.

No big preference here. I guess it could be good indeed to keep it open and let the user close it manually 👍 No big preference though.

@mattab
Copy link
Member

mattab commented Mar 14, 2021

Sounds slightly better to "keep it open and let the user close it manually" 👍

@flamisz
Copy link
Contributor Author

flamisz commented Mar 15, 2021

Hi @diosmosis, I made the changes according to your comments.
@mattab now the banner won't close until the user will close it.

Should I make a PR in the Whitelabel plugin, so we handle this new event and can disable showing this banner?

@flamisz flamisz added the Needs Review PRs that need a code review label Mar 15, 2021
@mattab
Copy link
Member

mattab commented Mar 15, 2021

Should I make a PR in the Whitelabel plugin, so we handle this new event and can disable showing this banner?

@flamisz Yes, it should be always disabled in White Label plugin, good that you thought about this one 👍

@diosmosis diosmosis merged commit dabc1ca into 4.x-dev Mar 17, 2021
@diosmosis diosmosis deleted the 16803-ask-users-to-refer-us branch March 17, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask users to refer us to other friends
5 participants