New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask users to refer us to other friends #17234
Conversation
I haven't find a way to share on I fixed a small bug with the feedback popup: it called the |
@flamisz If you want to make it a bit more complex, you could add a input field for people to enter their Mastodon URL and then redirect them to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, before I forget:
All texts should probably be translatable.
@Findus23 yes, that's a good point. for sure it should be. I will do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some potential UX issues (cc @mattab / @tsteur):
- I noticed if you click one link the bottom area disappears. So if a user clicks on twitter, it goes to twitter.com, then they go back and want to click on another link (say linkedin), they're no longer able to. It doesn't seem like that big of a deal given the scope of the change, but it's something I noticed.
@mattab / @tsteur can you look at and approve the ux and copy?
banner at the bottom of the page:
thank you popup after clicking refer:
plugins/Feedback/angularjs/refer-banner/refer-banner.controller.js
Outdated
Show resolved
Hide resolved
No big preference here. I guess it could be good indeed to keep it open and let the user close it manually 👍 No big preference though. |
Sounds slightly better to "keep it open and let the user close it manually" 👍 |
Hi @diosmosis, I made the changes according to your comments. Should I make a PR in the Whitelabel plugin, so we handle this new event and can disable showing this banner? |
@flamisz Yes, it should be always disabled in White Label plugin, good that you thought about this one 👍 |
Description:
fixes #16803
Review