@flamisz opened this Pull Request on February 19th 2021 Contributor

Description:

fixes #16803

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@flamisz commented on February 21st 2021 Contributor

I haven't find a way to share on mastodon with a link, so that button is hidden on the ui.
The FB share currently not working, as matomo.org is on spam-list at FB.

I fixed a small bug with the feedback popup: it called the remindMeLater method even when the user clicked on the never remind me button, so actually the user was reminded again in 90 days.

@Findus23 commented on February 22nd 2021 Member

@flamisz If you want to make it a bit more complex, you could add a input field for people to enter their Mastodon URL and then redirect them to https://mastodon.example/share?text=the%20text
grafik

@flamisz commented on February 22nd 2021 Contributor

One minor thing, before I forget:
All texts should probably be translatable.

@Findus23 yes, that's a good point. for sure it should be. I will do that

@tsteur commented on March 14th 2021 Member

I noticed if you click one link the bottom area disappears. So if a user clicks on twitter, it goes to twitter.com, then they go back and want to click on another link (say linkedin), they're no longer able to. It doesn't seem like that big of a deal given the scope of the change, but it's something I noticed.

No big preference here. I guess it could be good indeed to keep it open and let the user close it manually 👍 No big preference though.

@mattab commented on March 14th 2021 Member

Sounds slightly better to "keep it open and let the user close it manually" :+1:

@flamisz commented on March 15th 2021 Contributor

Hi @diosmosis, I made the changes according to your comments.
@mattab now the banner won't close until the user will close it.

Should I make a PR in the Whitelabel plugin, so we handle this new event and can disable showing this banner?

@mattab commented on March 15th 2021 Member

Should I make a PR in the Whitelabel plugin, so we handle this new event and can disable showing this banner?

@flamisz Yes, it should be always disabled in White Label plugin, good that you thought about this one :+1:

This Pull Request was closed on March 17th 2021
Powered by GitHub Issue Mirror