@flamisz opened this Pull Request on February 19th 2021 Contributor

Description:

refs #16803

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on February 21st 2021 Contributor

I haven't find a way to share on mastodon with a link, so that button is hidden on the ui.
The FB share currently not working, as matomo.org is on spam-list at FB.

I fixed a small bug with the feedback popup: it called the remindMeLater method even when the user clicked on the never remind me button, so actually the user was reminded again in 90 days.

@Findus23 commented on February 22nd 2021 Member

@flamisz If you want to make it a bit more complex, you could add a input field for people to enter their Mastodon URL and then redirect them to https://mastodon.example/share?text=the%20text
grafik

@flamisz commented on February 22nd 2021 Contributor

One minor thing, before I forget:
All texts should probably be translatable.

@Findus23 yes, that's a good point. for sure it should be. I will do that

Powered by GitHub Issue Mirror