Prevent possible error when accessing an index #17233
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://wordpress.org/support/topic/undefined-index-piwik_pro_ads_enabled/ I think this should fix the issue. It's technically only a workaround. Not sure why this would show up as an error. I will try to find out more to see if there's a general issue there.
diosmosis
reviewed
Feb 18, 2021
| $oldSettingValue = @$configGeneralSection['piwik_pro_ads_enabled']; | ||
| $oldSettingValue = false; | ||
| if (isset($configGeneralSection['piwik_pro_ads_enabled'])) { | ||
| $oldSettingValue = @$configGeneralSection['piwik_pro_ads_enabled']; |
There was a problem hiding this comment.
I suppose technically not but might also not hurt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
see https://wordpress.org/support/topic/undefined-index-piwik_pro_ads_enabled/
I think this should fix the issue. It's technically only a workaround. Not sure why this would show up as an error. I will try to find out more to see if there's a general issue there.
Review