Allow nonce checks to provide custom required referrer URL. #17228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Feb 17, 2021
|
This pull request has been mentioned on Matomo forums. There might be relevant details there: https://forum.matomo.org/t/google-analytics-importer/48279/1 |
kl-he
added a commit
to bruun-rasmussen/matomo
that referenced
this pull request
Nov 28, 2022
Expected referrer would fail a nonce-check, if the referrer was empty or local. Introduced in 715ded1/matomo-org#17228. This fix "reverts" to a pure nonce-check, if referrer is empty or local. Issue encountered using the the GoogleAnalyticsImporter, also referred to in matomo-org#17228.
11 tasks
sgiehl
added a commit
that referenced
this pull request
Mar 16, 2023
* Allow empty referrer with expected referrer set Expected referrer would fail a nonce-check, if the referrer was empty or local. Introduced in 715ded1/#17228. This fix "reverts" to a pure nonce-check, if referrer is empty or local. Issue encountered using the the GoogleAnalyticsImporter, also referred to in #17228. * Fixed misunderstanding with localhost-handling Previous fix would allow localhost, even though expectedReferrerHost specified something else. If a referrer is present, it must fail if it is not localhost or expectedReferrerHost. * Updated some comments to match what is happening * Renamed expectedReferrer to allowedReferrer Renamed expectedReferrerHost to allowedReferrerHost. Also updated doc-blocks and comments, to reflect the changes. * Updated comments * Merged 4.x-dev * apply some fixes * fix test --------- Co-authored-by: Klaus Heigren <klh@bruun-rasmussen.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For the GoogleAnalyticsImporter the oauth nonce check fails since the referrer is google. In this case we want to ensure it is from google and not a local URL.
Review