16990 export url token #17227
Merged
16990 export url token #17227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Feb 17, 2021
plugins/CoreHome/angularjs/report-export/reportexport.directive.js
Outdated
Show resolved
Hide resolved
sgiehl
added
the
not-in-changelog
sgiehl
requested changes
Feb 17, 2021
diosmosis
requested changes
Feb 18, 2021
| @@ -61,7 +61,8 @@ | |||
| </div> | |||
|
|
|||
| <div class="col l12" ng-show="showUrl"> | |||
| <textarea piwik-select-on-focus readonly class="exportFullUrl" title="{{ 'CoreHome_ExportTooltip'|translate }}">{{ getExportLink() }}</textarea> | |||
| <textarea piwik-select-on-focus readonly class="exportFullUrl">{{ getExportLinkWithoutToken() }}</textarea> | |||
| <div class="tooltip" ng-bind-html="'CoreHome_ExportTooltipWithLink'|translate:'<a target=_blank href=\'/index.php?module=UsersManager&action=userSecurity\'>':'</a>':'ENTER_YOUR_TOKEN_AUTH_HERE'"></div> | |||
There was a problem hiding this comment.
This URL starting w/ /index.php will break on subdirectory installs, correct?
There was a problem hiding this comment.
good catch, thanks. I'll check it.
There was a problem hiding this comment.
hi @diosmosis I fixed this, using directory-relative URL instead of origin-relative.
diosmosis
reviewed
Feb 22, 2021
plugins/CoreHome/angularjs/report-export/reportexport.popover.html
Outdated
Show resolved
Hide resolved
diosmosis
reviewed
Feb 22, 2021
plugins/CoreHome/angularjs/report-export/reportexport.directive.js
Outdated
Show resolved
Hide resolved
added 2 commits
February 23, 2021 14:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix for #16990
Review