Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitignore to exclude misc/user/.htaccess #17226

Merged
merged 1 commit into from Feb 17, 2021
Merged

Update .gitignore to exclude misc/user/.htaccess #17226

merged 1 commit into from Feb 17, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Feb 16, 2021

Description:

When I installed and run Matomo locally, the /matomo/misc/user/.htaccess file was generated. This is not included in the .gitignore.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Feb 17, 2021
@tsteur tsteur added this to the 4.2.0 milestone Feb 17, 2021
@diosmosis diosmosis merged commit 96ea43a into 4.x-dev Feb 17, 2021
@diosmosis diosmosis deleted the update-gitignore branch February 17, 2021 05:01
@diosmosis
Copy link
Member

👍

@mattab mattab changed the title Update .gitignore Update .gitignore to exclude misc/user/.htaccess Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flamisz @diosmosis @tsteur