Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible comparison error #17222

Merged
merged 1 commit into from Feb 15, 2021
Merged

Fix possible comparison error #17222

merged 1 commit into from Feb 15, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 15, 2021

Description:

fixes #17212

@diosmosis feel free to merge or add another test if needed.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 15, 2021
@diosmosis diosmosis merged commit 9a06163 into 4.x-dev Feb 15, 2021
@diosmosis diosmosis deleted the fixcompare branch February 15, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
2 participants
@sgiehl @diosmosis