Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when memory_limit = -1 #17218

Merged
merged 4 commits into from Feb 15, 2021
Merged

Fix warning when memory_limit = -1 #17218

merged 4 commits into from Feb 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2021

Description:

When memory_limit = -1 (no limit) there is a warning, I did not find issue

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

When memory_limit = -1 (no limit) there is a warning
@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 15, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Feb 15, 2021
@sgiehl
Copy link
Member

sgiehl commented Feb 15, 2021

@okom3pom Thanks for your contribution!

@sgiehl sgiehl merged commit e8f4620 into matomo-org:4.x-dev Feb 15, 2021
@ghost
Copy link
Author

ghost commented Feb 15, 2021

Thank you too for the job !

@ghost ghost deleted the warning-memory-limit branch February 15, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants