Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jquery location in page overlay #17217

Merged
merged 1 commit into from Feb 14, 2021
Merged

Fix jquery location in page overlay #17217

merged 1 commit into from Feb 14, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 12, 2021

Description:

Page Overlay might not be working if jQuery is not present

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 12, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Feb 12, 2021
tsteur added a commit to matomo-org/matomo-for-wordpress that referenced this pull request Feb 14, 2021
@diosmosis diosmosis merged commit 0f63368 into 4.x-dev Feb 14, 2021
@diosmosis diosmosis deleted the pageoverlayjquery branch February 14, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants