@diosmosis opened this Pull Request on February 12th 2021 Member

Description:

fixes the following bugs:

  • do not do authorized to archive check when browser archiving is disabled in ArchiveSelector::getArchiveIds(). that function is only ever called when browser archiving is disabled so the request will never be authorized to archive, and we want to look at the latest invalidated archive if present.
  • when selecting archives we want to select all partial archives not just the latest for a plugin. I think those changes were put in to get a test to pass, but since this function didn't have tests didn't notice the problem. This is needed for report specific invalidations.
  • in the browser archiving / trigger=archivephp archiving path, the partial archive detection was not pulling partial archives newer than the latest known all plugins archive. fixed and with a test change that shows the error.

CC @tsteur

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on February 16th 2021 Member

@tsteur can you take a look at this PR?

@tsteur commented on February 17th 2021 Member

looks good @diosmosis

This Pull Request was closed on February 17th 2021
Powered by GitHub Issue Mirror