Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a couple bugs in archive querying when browser archiving is disabled #17216

Merged
merged 4 commits into from Feb 17, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Feb 12, 2021

Description:

fixes the following bugs:

  • do not do authorized to archive check when browser archiving is disabled in ArchiveSelector::getArchiveIds(). that function is only ever called when browser archiving is disabled so the request will never be authorized to archive, and we want to look at the latest invalidated archive if present.
  • when selecting archives we want to select all partial archives not just the latest for a plugin. I think those changes were put in to get a test to pass, but since this function didn't have tests didn't notice the problem. This is needed for report specific invalidations.
  • in the browser archiving / trigger=archivephp archiving path, the partial archive detection was not pulling partial archives newer than the latest known all plugins archive. fixed and with a test change that shows the error.

CC @tsteur

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

…led: do not do authorized to archive check when looking for invalidated archives in query and look at all latest partial archives when selecting as is done when request is authorized to archive
@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 12, 2021
@diosmosis diosmosis added this to the 4.2.0 milestone Feb 12, 2021
@diosmosis
Copy link
Member Author

@tsteur can you take a look at this PR?

@tsteur
Copy link
Member

tsteur commented Feb 17, 2021

looks good @diosmosis

@diosmosis diosmosis merged commit 419699c into 4.x-dev Feb 17, 2021
@diosmosis diosmosis deleted the fix-non-browser-archive-querying branch February 17, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants