New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archiver: do not create done flags like "done." #17215
Conversation
@diosmosis would this be causing reading archives that were created with this flag? or would that basically not have worked already anyway? |
@tsteur if there were already archives made w/ |
@diosmosis could be done. Just trying to understand: Would it be otherwise an issue to having flags with |
For leaving them, I think the only issue is if they're no longer queried and |
Note: I did see them created in prod when making plugin specific archives, maybe nowhere else. |
Also quickly another question: Would it cause issues if there are afterwards maybe two archives with a |
I'm not sure what you mean? After the update, having two archives w/ |
All good then 👍 |
merging this, fyi @tsteur |
Description:
Noticed calling
getDoneStringFlagFor
w/$plugin = false
whenpluginOnly=1
can result in done flags likedone.
.Review