Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiver: do not create done flags like "done." #17215

Merged
merged 4 commits into from Feb 15, 2021

Conversation

diosmosis
Copy link
Member

Description:

Noticed calling getDoneStringFlagFor w/ $plugin = false when pluginOnly=1 can result in done flags like done..

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Feb 12, 2021
@diosmosis diosmosis added this to the 4.2.0 milestone Feb 12, 2021
@tsteur
Copy link
Member

tsteur commented Feb 14, 2021

@diosmosis would this be causing reading archives that were created with this flag? or would that basically not have worked already anyway?

@diosmosis
Copy link
Member Author

@tsteur if there were already archives made w/ done., it might be an issue... we could have an update to change those I guess (an update where name = 'done.'?

@tsteur
Copy link
Member

tsteur commented Feb 14, 2021

@diosmosis could be done. Just trying to understand: Would it be otherwise an issue to having flags with done.? But all good to add such an update script and fixing it

@diosmosis
Copy link
Member Author

Would it be otherwise an issue to having flags with done.?

For leaving them, I think the only issue is if they're no longer queried and done archives aren't present. Now it might be an issue in that we might not be querying them properly? It's hard to tell w/ this issue exactly where it causes problems.

@diosmosis
Copy link
Member Author

Note: I did see them created in prod when making plugin specific archives, maybe nowhere else.

@tsteur
Copy link
Member

tsteur commented Feb 14, 2021

Also quickly another question: Would it cause issues if there are afterwards maybe two archives with a done flag? And they might contain different reports? I know it's a bit hard to say what would happen. I could imagine that some archive may be deleted or reports would be only read from one archive?

@diosmosis
Copy link
Member Author

Would it cause issues if there are afterwards maybe two archives with a done flag?

I'm not sure what you mean? After the update, having two archives w/ done should be fine since that's what we want (all archives would have the done flag or done w/ plugin/segment.

@tsteur
Copy link
Member

tsteur commented Feb 14, 2021

All good then 👍

@diosmosis
Copy link
Member Author

merging this, fyi @tsteur

@diosmosis diosmosis merged commit 060d4a8 into 4.x-dev Feb 15, 2021
@diosmosis diosmosis deleted the empty-plugin-done-flag branch February 15, 2021 05:40
@mattab mattab changed the title do not end up creating done flags like "done." Archiver: do not create done flags like "done." Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants