Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deactivate a core plugin during update #17213

Merged
merged 1 commit into from Feb 11, 2021
Merged

Don't deactivate a core plugin during update #17213

merged 1 commit into from Feb 11, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 11, 2021

Description:

refs #17181

Basically, we should stop the updater if there is an error with a core plugin. Eg when adding a referrer column we shouldn't simply disable the referrer plugin as it can cause unexpected issues as Matomo doesn't always work when disabling a core plugin.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Feb 11, 2021
@tsteur tsteur added this to the 4.2.0 milestone Feb 11, 2021
@diosmosis diosmosis merged commit 494812d into 4.x-dev Feb 11, 2021
@diosmosis diosmosis deleted the updatecore branch February 11, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants