@gecon opened this Pull Request on February 8th 2021 Contributor

Fix for PHP 8.0 compatibility: In PHP 8 GdImage class objects replace GD image resources. Custom logo upload was not working.

Description:

Using PHP 8.0 dos not allow custom logo upload, because GdImage class objects replace GD image resources.
Proposed fix checks for GDImage class object too and custom logo is working.

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@sgiehl commented on February 8th 2021 Member

Hi @gecon
Thanks for creating the Pull Request. I will try to review this later, so we can include it into our next release.

@sgiehl commented on February 8th 2021 Member

Tested locally with PHP 7 and PHP 8. Custom Logo upload now works on both. Thanks @gecon for providing the patch 👍

This Pull Request was closed on February 8th 2021
Powered by GitHub Issue Mirror