CustomLogo upload not working with PHP8 #17205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for PHP 8.0 compatibility: In PHP 8 GdImage class objects replace GD image resources. Custom logo upload was not working.
sgiehl
added
Needs Review
|
Hi @gecon |
sgiehl
reviewed
Feb 8, 2021
sgiehl
approved these changes
Feb 8, 2021
|
Tested locally with PHP 7 and PHP 8. Custom Logo upload now works on both. Thanks @gecon for providing the patch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PHP 8.0 compatibility: In PHP 8 GdImage class objects replace GD image resources. Custom logo upload was not working.
Description:
Using PHP 8.0 dos not allow custom logo upload, because GdImage class objects replace GD image resources.
Proposed fix checks for GDImage class object too and custom logo is working.
Review