Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow including host name in Actions URL reports instead of merging paths regardless of URL. #17203

Closed
wants to merge 3 commits into from

Conversation

diosmosis
Copy link
Member

Description:

Fixes #14104

CC @tsteur, @mattab

Seemed like a simple change so I created a poc. Note: after creating it, I thought it might be good to use a measurable setting instead of an INI config (though the INI config could set the default). Either way, a small change.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Feb 8, 2021
@mattab mattab modified the milestones: 4.2.0, 4.3.0 Feb 19, 2021
@diosmosis diosmosis removed the Needs Review PRs that need a code review label Mar 2, 2021
@diosmosis diosmosis marked this pull request as draft March 2, 2021 05:39
@mattab mattab modified the milestones: 4.3.0, 4.4.0 May 26, 2021
@tsteur
Copy link
Member

tsteur commented Jul 27, 2021

Will close this one as it's not high priority and issue is not scheduled.

@tsteur tsteur closed this Jul 27, 2021
@uschindler
Copy link

uschindler commented May 11, 2023

This pull request looks like it would fix many complaints about not seeing the subdomain/domain in the pages report. Why was it closed? I would wish to have this in 5.0.

@sgiehl sgiehl deleted the 14104-config-to-include-host-in-actions branch January 9, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subdomains paths in Pages / other reports
4 participants