Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include report column in duplicate check when inserting archive invalidations. #17192

Merged
merged 2 commits into from Feb 5, 2021

Conversation

diosmosis
Copy link
Member

Description:

When checking for duplicates we have to include the report, otherwise reArchiveReport w/ a custom report name may not work correctly.

@sgiehl this should fix the CustomReports test failure. It's a simple change so merging it now.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 5, 2021
@diosmosis diosmosis added this to the 4.2.0 milestone Feb 5, 2021
@diosmosis diosmosis merged commit 540ed05 into 4.x-dev Feb 5, 2021
@diosmosis diosmosis deleted the archive-invalidation-report-bug branch February 5, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant