Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 204 response for bulk requests to avoid possible CORB issue #17180

Merged
merged 2 commits into from Feb 4, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 2, 2021

Description:

fixes #17159

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

…_image=0

and automatically add that for all bulk requests sent be piwik.js
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 2, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Feb 2, 2021
@sgiehl
Copy link
Member Author

sgiehl commented Feb 2, 2021

build js

@diosmosis
Copy link
Member

given this could potentially be a bc break for some users, should we mention this change in the developer changelog?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 4, 2021

guess that makes sense. will add it to the changelog

@diosmosis
Copy link
Member

Actually I misread the PR, it doesn't need an entry in the developer changelog. I'll remove it and merge.

@diosmosis diosmosis merged commit a2fd1e5 into 4.x-dev Feb 4, 2021
@diosmosis diosmosis deleted the bulkresponse branch February 4, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking requests might not be loaded because of CORB
2 participants