@sgiehl opened this Pull Request on February 2nd 2021 Member

Description:

fixes #17159

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on February 2nd 2021 Member

build js

@diosmosis commented on February 4th 2021 Member

given this could potentially be a bc break for some users, should we mention this change in the developer changelog?

@sgiehl commented on February 4th 2021 Member

guess that makes sense. will add it to the changelog

@diosmosis commented on February 4th 2021 Member

Actually I misread the PR, it doesn't need an entry in the developer changelog. I'll remove it and merge.

This Pull Request was closed on February 4th 2021
Powered by GitHub Issue Mirror