Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement when using only visit custom dimensions (one less update query per tracker request) #17174

Closed
tsteur opened this issue Feb 1, 2021 · 1 comment
Closed

Performance improvement when using only visit custom dimensions (one less update query per tracker request) #17174

tsteur opened this issue Feb 1, 2021 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it. worksforme The issue cannot be reproduced and things work as intended.

Comments

@tsteur
Copy link
Member

tsteur commented Feb 1, 2021 •
edited

I didn't really look in the code but thinking this query here only needs to be executed when an action custom dimension is used: https://github.com/matomo-org/matomo/blob/4.1.1/plugins/CustomDimensions/Tracker/CustomDimensionsRequestProcessor.php#L49-L51

Not sure it's used for visit custom dimension as a time spent on one action wouldn't be that useful? If I see this right then we shouldn't execute it if only visit custom dimensions are used.

Not sure if time_spent is used in any other way.
@tsteur tsteur added c: Performance For when we could improve the performance / speed of Matomo. c: Custom Dimensions For issues related to the Custom Dimensions plugin. labels Feb 1, 2021
@tsteur tsteur added this to the 4.4.0 milestone Feb 1, 2021
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Feb 1, 2021
@tsteur
Copy link
Member Author

tsteur commented Feb 1, 2021

actually this is already done. just the method name was not clear

@tsteur tsteur closed this as completed Feb 1, 2021
@tsteur tsteur added worksforme The issue cannot be reproduced and things work as intended. and removed Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Custom Dimensions For issues related to the Custom Dimensions plugin. c: Performance For when we could improve the performance / speed of Matomo. labels Feb 1, 2021
@tsteur tsteur removed this from the 4.4.0 milestone Feb 1, 2021
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsteur