Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix map names in Switzerland #17172

Merged
merged 2 commits into from Feb 1, 2021
Merged

fix map names in Switzerland #17172

merged 2 commits into from Feb 1, 2021

Conversation

Findus23
Copy link
Member

fixes #17171

I have no idea why they are incorrect (Umlauts work fine in Austria), but I think this should be fixed simply be editing the names in the SVG (as the other ones are correct).

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label Jan 31, 2021
@diosmosis diosmosis merged commit 49a1148 into 4.x-dev Feb 1, 2021
@diosmosis diosmosis deleted the fix-switzerland-names branch February 1, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues on map naming
2 participants
@Findus23 @diosmosis