@diosmosis opened this Pull Request on January 30th 2021 Member

Description:

Fixes #17123

@tsteur found the fix. The cause is since we call CoreAdminHome.archiveReports now instead of API.get, the dependent archive isn't implicitly created. Adding an archiver for VisitFrequency fixes this, though I'm not sure if we want to maintain the old behavior.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on January 31st 2021 Member

sounds good for now 👍 . I don't think it affects any other *.get methods so should be fine IMO

@diosmosis commented on January 31st 2021 Member

@tsteur will also add an update to automatically invalidate, unless you think that's a bad idea.

@tsteur commented on February 1st 2021 Member

@diosmosis I'm assuming this would mean we rearchive all the data from the last few months not just this report? cc @mattab

@diosmosis commented on February 1st 2021 Member

@tsteur

I'm assuming this would mean we rearchive all the data from the last few months not just this report?

I think we can just re-archive visitfrequency from start of matomo 4 upgrade to now. We just need to trigger the VisitFrequency archiver which will process dependent archives. So we shouldn't need to do every archive.

@tsteur commented on February 1st 2021 Member

👍 sounds good

@diosmosis commented on February 1st 2021 Member

added the update file

This Pull Request was closed on February 3rd 2021
Powered by GitHub Issue Mirror