Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "Compare to" button design has slightly regressed on firefox only #17162

Closed
mattab opened this issue Jan 28, 2021 · 2 comments · Fixed by #17348
Closed

the "Compare to" button design has slightly regressed on firefox only #17162

mattab opened this issue Jan 28, 2021 · 2 comments · Fixed by #17348
Assignees
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 28, 2021

the "Compare to" button design has slightly regressed on firefox only (seems ok on chrome)?
here is how it looks on cloud and demo2 on FF:

Screenshot from 2021-01-29 11-06-25

but it used to look like https://matomo.org/wp-content/uploads/2019/10/Screenshot-from-2019-10-29-17-26-12.png

Would be great to restore the look. (as the calendar is very often used)

@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jan 28, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 28, 2021
@sgiehl
Copy link
Member

sgiehl commented Jan 29, 2021

That actually looks fine for me locally and on demo2 using Firefox on Windows.
But to be honest the current layout isn't good at all, as it won't work for various languages besides of English, as Compare to: has longer translations. For German it's Vergleichen mit:, which is always too long and the layout "breaks"

@mattab mattab modified the milestones: 4.2.0, 4.3.0 Feb 22, 2021
@flamisz flamisz self-assigned this Mar 16, 2021
@flamisz
Copy link
Contributor

flamisz commented Mar 16, 2021

I see what's happening here. The calendar itself positioned absolutely, without any width, so it uses the parent's width (which is too small, so grows to fit the period). If we see in smaller screen (<600px) actually it looks good (see screenshot), because we changing the positions above the calendar, so under 600px the parent element will be the whole top_controls class.

Easy fix is too set a fix width to the calendar (of course be careful with the mobile view and max-width).

Screen Shot 2021-03-16 at 3 28 30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants