Ignore query failure in Matomo for WordPress when checking if logtmptable exists #17158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able exists Needed this in matomo-org/matomo-for-wordpress#417 and documented it in https://github.com/matomo-org/wp-matomo/wiki/Database refs matomo-org/matomo-for-wordpress#416 refs https://wordpress.org/support/topic/error-in-php-log-after-manual-update-to-v4-1-2/ refs https://wordpress.org/support/topic/archive-warning-error-unserializing-wp_matomo_logtmpsegment/ refs https://wordpress.org/support/topic/php-error-with-vn-4-1-2/ Previously, I had detected this query like this: https://github.com/matomo-org/wp-matomo/pull/417/files#diff-c4e75ddbbcdde3ba408b5a87e273371dd3420a5d0b90a87bb4295e81787cdc31L365 but now it looks like `SELECT /*+MAX_EXECUTION_TIME....` and it's quite hard to detect it without trying to reconstruct the query or using regex. This way it'll be more future proof
tsteur
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Needed this in matomo-org/matomo-for-wordpress#417 and documented it in https://github.com/matomo-org/wp-matomo/wiki/Database
refs matomo-org/matomo-for-wordpress#416
refs https://wordpress.org/support/topic/error-in-php-log-after-manual-update-to-v4-1-2/
refs https://wordpress.org/support/topic/archive-warning-error-unserializing-wp_matomo_logtmpsegment/
refs https://wordpress.org/support/topic/php-error-with-vn-4-1-2/
Previously, I had detected this query like this: https://github.com/matomo-org/wp-matomo/pull/417/files#diff-c4e75ddbbcdde3ba408b5a87e273371dd3420a5d0b90a87bb4295e81787cdc31L365 but now it looks like
SELECT /*+MAX_EXECUTION_TIME....and it's quite hard to detect it without trying to reconstruct the query or using regex. This way it'll be more future proofReview