New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https for urls in visitor details if host is defined with https in site #17151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked. Left 2 comments. Can you also already prepare an FAQ for this? Was wondering if we need to do the same for Actions.getPageUrls report for example maybe?
Afaik Regarding FAQ: Not sure which question it actually should answer. |
Regarding the FAQ: I meant something like:
Sounds good. I think it be good to have consistent behaviour there if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments. Tested locally and it works 👍
1c643fe
to
6ceadd6
Compare
@diosmosis I've applied some changes. Let me know if it's good to merge now. |
Description:
refs #5312, #12586
Review