@diosmosis opened this Pull Request on January 26th 2021 Member

Description:

Currently we are getting segments from the segment table directly, when it's possible to also add segments to archive to the config and in events, so we want to use the Rules method instead.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on January 27th 2021 Member

@sgiehl tests should be fixed

This Pull Request was closed on January 27th 2021
Powered by GitHub Issue Mirror