Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Rules method instead of getting stored segments directly to pre-archive extra segments #17148

Merged
merged 2 commits into from Jan 27, 2021

Conversation

diosmosis
Copy link
Member

Description:

Currently we are getting segments from the segment table directly, when it's possible to also add segments to archive to the config and in events, so we want to use the Rules method instead.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jan 26, 2021
@diosmosis diosmosis added this to the 4.2.0 milestone Jan 26, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but there are some integration tests failing

@diosmosis
Copy link
Member Author

@sgiehl tests should be fixed

@diosmosis diosmosis merged commit aefb757 into 4.x-dev Jan 27, 2021
@diosmosis diosmosis deleted the all-segments branch January 27, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants